Re: [PATCH v5 2/5] arm64: dts: agilex: add soc0 label

From: Krzysztof Kozlowski
Date: Wed Jan 29 2025 - 04:46:13 EST


On 27/01/2025 18:35, Matthew Gerlach wrote:
> Add a label to the soc@0 device tree node.
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> ---
> v3:
> - Remove accepted patches from patch set.
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index 1235ba5a9865..144fe74e929e 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -152,7 +152,7 @@ usbphy0: usbphy {
> compatible = "usb-nop-xceiv";
> };
>
> - soc@0 {
> + soc0: soc@0 {
This shouldn't be a separate commit, really. It serves no purpose to
just add the label. Just like you do not add just a define in a driver
without its user. Label like this itself is pointless. It's useful for
something, so this should be squashed.

Best regards,
Krzysztof