Re: [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type

[Hans de Goede]

Hi,

On 29-Jan-25 4:28 PM, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
> 
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans



> ---
>  drivers/mfd/intel_soc_pmic_crc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index 879fbf5cd162..41429f9bcb69 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = {
>  	.val_bits = 8,
>  
>  	.max_register = CRYSTAL_COVE_MAX_REGISTER,
> -	.cache_type = REGCACHE_NONE,
>  };
>  
>  static const struct regmap_irq crystal_cove_irqs[] = {