Re: [PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache_type

From: Chris Packham
Date: Wed Jan 29 2025 - 14:41:18 EST


Hi Andy,

On 30/01/2025 04:29, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
>
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

> ---
> drivers/spi/spi-realtek-rtl-snand.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-realtek-rtl-snand.c b/drivers/spi/spi-realtek-rtl-snand.c
> index cd0484041147..741cf2af3e91 100644
> --- a/drivers/spi/spi-realtek-rtl-snand.c
> +++ b/drivers/spi/spi-realtek-rtl-snand.c
> @@ -364,7 +364,6 @@ static int rtl_snand_probe(struct platform_device *pdev)
> .reg_bits = 32,
> .val_bits = 32,
> .reg_stride = 4,
> - .cache_type = REGCACHE_NONE,
> };
> int irq, ret;
>