Re: [PATCH v5 5/6] kernfs: Use RCU to access kernfs_node::parent.

From: Tejun Heo
Date: Wed Jan 29 2025 - 15:29:11 EST


On Wed, Jan 29, 2025 at 09:26:14PM +0100, Sebastian Andrzej Siewior wrote:
...
> > Hmm... I would have gone with using the same accessor everywhere but am not
> > sure how strongly I feel about it. I don't think it's useful to worry about
> > the overhead of the extra lockdep annotations in debug builds. Ignoring that
> > and just considering code readability, what would you do?
>
> It is your call. I would prefer to open code that part that we do only
> rely on RCU here but sure understand that you don't care about the
> details and want to have only one accessor.

It's kinda nitpicky. Let's just keep what you did.

Thanks.

--
tejun