Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,wcnss-pil: Add support for single power-domain platforms

[Luca Weiss]

On woensdag 29 januari 2025 19:44:54 Midden-Europese standaardtijd Krzysztof 
Kozlowski wrote:
> On 29/01/2025 18:51, Luca Weiss wrote:
> > From: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> > 
> > Support platforms such as MSM8226 and MSM8974 with only one power rail
> > (CX) modelled as power domain while MX and PX are regulators.
> > 
> > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> > [luca: reword commit message]
> > Signed-off-by: Luca Weiss <luca@xxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-
pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
> > index 
8e033b22d28cfa8203234f744b3b408e976e20c3..d3c71bcf0f02122eb0dae214f135d8d7f71a9600 
100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
> > @@ -69,9 +69,11 @@ properties:
> >        CX regulator to be held on behalf of the booting of the WCNSS core.
> >  
> >    power-domains:
> > +    minItems: 1
> >      maxItems: 2
> >  
> >    power-domain-names:
> > +    minItems: 1
> 
> 
> This should be further narrowed in allOf:if:then per each variant,
> because now you say that all devices here can have only one power
> domain... unless the compatibles do not allow that, but then explain in
> commit msg.

Yes, the compatibles are so broad that they cannot be used to narrow this 
down. I can add this information in v2.

I'd add something like the following. Let me know if that isn't clear enough.

"Due to the compatibles qcom,pronto-vN-pil being so broad we cannot narrow 
this down by SoC without introducing new compatibles."

Regards
Luca

> 
> Best regards,
> Krzysztof
>