Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible array member

From: Gustavo A. R. Silva
Date: Wed Jan 29 2025 - 19:02:31 EST




On 30/01/25 07:08, Halil Pasic wrote:
On Thu, 16 Jan 2025 14:18:59 +0100
Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:

Replace the deprecated one-element array with a modern flexible array
member in the struct ap_matrix_dev.


I'm not sure I understand the value of this. What we have here is not
a flexible array but a one element array. Something that in the generic
case could be many but particularly for vfio-ap is always one.

You are correct. Only fake flexible arrays should be transformed into
C99 flex-array members [1].

Thanks
-Gustavo

[1] https://lwn.net/Articles/908817/