Re: [PATCH net 2/3] net: ethtool: tsconfig: Fix ts filters and types enums size check
From: Jakub Kicinski
Date: Wed Jan 29 2025 - 19:45:19 EST
On Tue, 28 Jan 2025 16:35:47 +0100 Kory Maincent wrote:
> Fix the size check for the hwtstamp_tx_types and hwtstamp_rx_filters
> enumerations.
This is just a code cleanup, the constants are way smaller than 32
today. The assert being too restrictive makes no functional difference.
> Align this check with the approach used in tsinfo for
> consistency and correctness.
First-principles based explanation of why 32 is the correct value would
be much better than just alignment. Otherwise reviewer has to figure out
whether we should be changing from >= to > or vice versa...
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> Fixes: 6e9e2eed4f39 ("net: ethtool: Add support for tsconfig command to get/set hwtstamp config")
--
pw-bot: cr