Re: [PATCH 1/3] Revert "tty/serial: Add kgdb_nmi driver"
From: Andy Shevchenko
Date: Thu Jan 30 2025 - 03:27:45 EST
On Wed, Jan 29, 2025 at 08:25:50AM -0800, Douglas Anderson wrote:
> This reverts commit 0c57dfcc6c1d037243c2f8fbf62eab3633326ec0.
>
> The functionality was supoosed to be used by a later patch in the
> series that never landed [1]. Drop it.
>
> NOTE: part of functionality was already reverted by commit
> 39d0be87438a ("serial: kgdb_nmi: Remove unused knock code"). Also note
> that this revert is not a clean revert given code changes that have
> happened in the meantime.
>
> It's obvious that nobody is using this code since the two exposed
> functions (kgdb_register_nmi_console() and
> kgdb_unregister_nmi_console()) are both no-ops if
> "arch_kgdb_ops.enable_nmi" is not defined. No architectures define it.
Fine with me.
Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> [1] https://lore.kernel.org/lkml/1348522080-32629-9-git-send-email-anton.vorontsov@xxxxxxxxxx/
It might be possible to use Link tag here in a form
Link: URL [1]
--
With Best Regards,
Andy Shevchenko