Re: [PATCH net 3/3] net: ethtool: tsconfig: Fix netlink type of hwtstamp flags

[Kory Maincent]

On Wed, 29 Jan 2025 16:49:07 -0800
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Tue, 28 Jan 2025 16:35:48 +0100 Kory Maincent wrote:
> > Fix the netlink type for hardware timestamp flags, which are represented
> > as a bitset of flags. Although only one flag is supported currently, the
> > correct netlink bitset type should be used instead of u32. Address this
> > by adding a new named string set description for the hwtstamp flag
> > structure.  
> 
> Makes sense, please mention explicitly in the commit message that the
> code has been introduced in the current release so the uAPI change is
> still okay.

Ack.

> In general IMHO YNL makes the bitset functionality less important.

Do you mean you prefer u32 for bitfield instead of the bitset type? Why?

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com