Re: [PATCH] rust: task: make Pid type alias public

From: Fiona Behrens
Date: Thu Jan 30 2025 - 06:33:31 EST


Alice Ryhl <aliceryhl@xxxxxxxxxx> writes:

> The Pid type alias represents the integer type used for pids in the
> kernel. It's the Rust equivalent to pid_t, and there are various methods
> on Task that use Pid as the return type.
>
> Binder needs to use Pid as the type for function arguments and struct
> fields in many places. Thus, make the type public so that Binder can
> access it.
>
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

Reviewed-by: Fiona Behrens <me@xxxxxxxxxx>

> ---
> rust/kernel/task.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/task.rs b/rust/kernel/task.rs
> index 07bc22a7645c..49012e711942 100644
> --- a/rust/kernel/task.rs
> +++ b/rust/kernel/task.rs
> @@ -106,7 +106,7 @@ unsafe impl Send for Task {}
> unsafe impl Sync for Task {}
>
> /// The type of process identifiers (PIDs).
> -type Pid = bindings::pid_t;
> +pub type Pid = bindings::pid_t;
>
> /// The type of user identifiers (UIDs).
> #[derive(Copy, Clone)]
>
> ---
> base-commit: ceff0757f5dafb5be5205988171809c877b1d3e3
> change-id: 20250130-task-pid-pub-484458aec19b
>
> Best regards,