Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible array member
From: Alexander Gordeev
Date: Thu Jan 30 2025 - 06:37:48 EST
On Thu, Jan 30, 2025 at 11:46:15AM +0100, Halil Pasic wrote:
> > > I'm not sure I understand the value of this. What we have here is not
> > > a flexible array but a one element array. Something that in the generic
> > > case could be many but particularly for vfio-ap is always one.
> >
> > You are correct. Only fake flexible arrays should be transformed into
> > C99 flex-array members [1].
> >
> > Thanks
> > -Gustavo
> >
> > [1] https://lwn.net/Articles/908817/
> >
>
> Thanks! Alex, what do we do with this then? I think you picked it up
> yesterday late. And I think, it might make sense to make this look
> less like a fake flex-array...
Dropped.
Thanks for looking into it!