Re: [PATCH 1/3] gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0
From: Markus Mayer
Date: Thu Jan 30 2025 - 17:00:28 EST
On Thu, 30 Jan 2025 at 13:33, Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:
>
> On 1/30/25 09:10, Artur Weber wrote:
> > The GPIO lock/unlock functions clear/write a bit to the relevant
> > register for each bank. However, due to an oversight the bit that
> > was being written was based on the total GPIO number, not the index
> > of the GPIO within the relevant bank, causing it to fail for any
> > GPIO above 32 (thus any GPIO for banks above bank 0).
> >
> > Fix lock/unlock for these banks by using the correct bit.
> >
> > Fixes: bdb93c03c550 ("gpio: bcm281xx: Centralize register locking")
> > Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx>
>
> Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
Wow. That recipient list brings back memories.
Also:
Reviewed-by: Markus Mayer <mmayer@xxxxxxxxxxxx>