Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible array member
From: Halil Pasic
Date: Fri Jan 31 2025 - 03:06:31 EST
On Thu, 30 Jan 2025 13:46:47 +0100
Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
> > > Thanks! Alex, what do we do with this then? I think you picked it up
> > > yesterday late. And I think, it might make sense to make this look
> > > less like a fake flex-array...
> >
> > Dropped.
> > Thanks for looking into it!
>
> Given that we already have 5dd4241964c8 ("vfio/ccw: replace one-element
> array with flexible-array member") applied, we now end up with inconsistent
> code. I'd prefer if we address _both_ code locations in a way that the code
> looks similar, and people won't send similar patches again and again.
>
Yes, I agree. We should make this not look like a fake flex array.
> Halil, since you started this discussion, can you address this please?
Sure! But I won't get around before late in the evening.
Regards,
Halil