Re: [PATCH v2] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo SE30 platform
From: Mark Pearson
Date: Fri Jan 31 2025 - 11:18:11 EST
Hi Guenter
On Fri, Jan 31, 2025, at 10:44 AM, Guenter Roeck wrote:
> On 1/16/25 10:29, Mark Pearson wrote:
>> Watchdog driver implementation for Lenovo SE30 platform.
>>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> ...
>> --- /dev/null
>> +++ b/drivers/watchdog/lenovo_se30_wdt.c
> ...
>> +
>> +static int lenovo_se30_wdt_set_timeout(struct watchdog_device *wdog,
>> + unsigned int timeout)
>> +{
>> + wdog->timeout = timeout;
>> + return 0;
>> +}
>> +
>
> This function, as implemented, is unnecessary. See watchdog_set_timeout()
> in drivers/watchdog/watchdog_dev.c.
>
Ah - good point. I'll remove this.
Thanks
Mark