Re: [PATCH 0/3] drm/msm/dsi/phy: Improvements around concurrent PHY_CMN_CLK_CFG[01]

From: Dmitry Baryshkov
Date: Fri Jan 31 2025 - 11:24:36 EST


On Fri, Jan 31, 2025 at 04:02:49PM +0100, Krzysztof Kozlowski wrote:
> Calling these improvements, not fixes, because I don't think we ever hit
> actual concurrency issue. Although if we ever hit it, it would be very
> tricky to debug and find the cause.

All of the patches miss Fixes: tags. Could you please provide those.

>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (3):
> drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG0 updated from driver side
> drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver
> drm/msm/dsi/phy: Do not overwite PHY_CMN_CLK_CFG1 when choosing bitclk source
>
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 50 ++++++++++++++++++++-----------
> 1 file changed, 33 insertions(+), 17 deletions(-)
> ---
> base-commit: 375ef7b3d85d8b0fa72092642582ca5b95a64e67
> change-id: 20250131-drm-msm-phy-pll-cfg-reg-7e5bf5aa9df6
>
> Best regards,
> --
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>

--
With best wishes
Dmitry