Re: [PATCH V5 1/5] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder

From: Rob Herring (Arm)
Date: Fri Jan 31 2025 - 14:42:17 EST


On Sat, 01 Feb 2025 00:02:38 +0530, Jishnu Prakash wrote:
> There are several files containing QCOM ADC macros for channel names
> right now in the include/dt-bindings/iio folder. Since all of these
> are specifically for adc, move the files to the
> include/dt-bindings/iio/adc folder.
>
> Also update all affected devicetree and driver files to fix compilation
> errors seen with this move and update documentation files to fix
> dtbinding check errors for the same.
>
> Acked-by: Lee Jones <lee@xxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> ---
> Changes since v4:
> - Updated some more devicetree files requiring this change.
>
> Changes since v3:
> - Updated files affected by adc file path change in /arch/arm, which
> were missed earlier. Updated some more new devicetree files requiring
> this change in /arch/arm64.
>
> Changes since v2:
> - Updated some more new devicetree files requiring this change.
>
> .../devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 8 ++++----
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +-
> .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 2 +-
> .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 6 +++---
> arch/arm/boot/dts/qcom/pm8226.dtsi | 2 +-
> arch/arm/boot/dts/qcom/pm8941.dtsi | 2 +-
> arch/arm/boot/dts/qcom/pma8084.dtsi | 2 +-
> arch/arm/boot/dts/qcom/pmx55.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm4125.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm6125.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm6150.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm6150l.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm660.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm660l.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8150.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8150l.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8916.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8937.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8950.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8953.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8994.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pmi632.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pmp8074.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pms405.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++--
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 4 ++--
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 2 +-
> .../arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 6 +++---
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 2 +-
> arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts | 6 +++---
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 8 ++++----
> drivers/iio/adc/qcom-spmi-adc5.c | 2 +-
> drivers/iio/adc/qcom-spmi-vadc.c | 2 +-
> include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm7325.h | 2 +-
> include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm8350.h | 2 +-
> .../dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm8350b.h | 2 +-
> .../dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmk8350.h | 2 +-
> .../dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmr735a.h | 2 +-
> .../dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmr735b.h | 2 +-
> .../dt-bindings/iio/{ => adc}/qcom,spmi-adc7-smb139x.h | 2 +-
> include/dt-bindings/iio/{ => adc}/qcom,spmi-vadc.h | 0
> 52 files changed, 66 insertions(+), 66 deletions(-)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm7325.h (98%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm8350.h (98%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm8350b.h (99%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmk8350.h (97%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmr735a.h (95%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmr735b.h (95%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-smb139x.h (93%)
> rename include/dt-bindings/iio/{ => adc}/qcom,spmi-vadc.h (100%)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
In file included from Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.example.dts:80:
./scripts/dtc/include-prefixes/dt-bindings/iio/adc/qcom,spmi-adc7-pmk8350.h:13:10: fatal error: dt-bindings/iio/adc/qcom,spmi-vadc.h: No such file or directory
13 | #include <dt-bindings/iio/adc/qcom,spmi-vadc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250131183242.3653595-2-jishnu.prakash@xxxxxxxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.