Re: [PATCH 1/2] AutoFDO: Remove the architecture specific config

[Yabin Cui]

Hi Rong,

Thanks for the patch! Sorry for the delay in testing it.
I will upload another patch to document steps for using ETM.

Tested-by: Yabin Cui <yabinc@xxxxxxxxxx>

Thanks,
Yabin



On Thu, Dec 19, 2024 at 9:20 AM Rong Xu <xur@xxxxxxxxxx> wrote:
>
> Thanks for the Acked-by.
>
> Regarding the ETM documentation change, I haven't forgotten it. I
> think it's best for Yabin to submit another patch (or revision of his
> previous patch), as he has done all the ETM side work.
>
> Best regards,
>
> -Rong
>
> On Thu, Dec 19, 2024 at 7:52 AM Will Deacon <will@xxxxxxxxxx> wrote:
> >
> > On Wed, Dec 11, 2024 at 02:29:42PM -0800, Rong Xu wrote:
> > > The CONFIG_AUTOFDO_CLANG option currently depends on
> > > ARCH_SUPPORTS_AUTOFDO_CLANG, but this dependency seems unnecessary.
> > >
> > > Remove ARCH_SUPPORTS_AUTOFDO_CLANG and allow users to control AutoFDO
> > > builds solely through CONFIG_AUTOFDO_CLANG. This simplifies the kconfig
> > > and avoids potential confusion.
> > >
> > > Signed-off-by: Rong Xu <xur@xxxxxxxxxx>
> > > Suggested-by: Will Deacon <will@xxxxxxxxxx>
> > > ---
> > >  arch/Kconfig     | 4 ----
> > >  arch/x86/Kconfig | 1 -
> > >  2 files changed, 5 deletions(-)
> >
> > Acked-by: Will Deacon <will@xxxxxxxxxx>
> >
> > However, you've dropped the previous hunk you had to
> > Documentation/dev-tools/autofdo.rst which had some text about using ETM
> > to collect fdo data on arm64. It seems like that might still be useful
> > to have?
> >
> > Will