Re: [PATCH 1/2] gpu: nova-core: add initial driver stub

[Danilo Krummrich]

On Sat, Feb 01, 2025 at 09:33:28AM +0100, Greg KH wrote:
> On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote:
> > +impl Gpu {
> > +    pub(crate) fn new(pdev: &pci::Device, bar: Devres<Bar0>) -> Result<impl PinInit<Self>> {
> > +        let spec = GpuSpec::new(&bar)?;
> > +        let fw = Firmware::new(pdev.as_ref(), &spec, "535.113.01")?;
> > +
> > +        dev_info!(
> > +            pdev.as_ref(),
> > +            "NVIDIA {:?} ({:#x})",
> > +            spec.chipset,
> > +            spec.boot0
> > +        );
> 
> When drivers work properly, they should be quiet, so can you move this
> to dev_dbg()?

Sure, the only reason I made this dev_info!() is because, as an initial
skeleton, the driver isn't doing anything else for now. So, I thought it would
be nice to have some sign of life.

Of course, the intention was to remove this, once there's any other sign of
life.