Re: [RFC PATCH 2/5] mfd: Add ROHM BD79124 ADC/GPO

[Matti Vaittinen]

On 31/01/2025 19:14, Jonathan Cameron wrote:
> On Fri, 31 Jan 2025 15:37:06 +0200
> Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
>
> > Add core driver for the ROHM BD79124 ADC / GPO.
> >
> > The core driver launches the sub-drivers for the pinmux/GPO and for the
> > IIO ADC. It also provides the regmap, and forwards the IRQ resource to
> > the ADC.
> >
> > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> As per response in cover letter. This is a common device combination and so
> far I don't think we ever bothered with an MFD. Lots of ADCs provide
> GPIO chips as well so I'd just squash it into the ADC driver.

You may be right with this. I still need to digest this a bit as I 
explaned in the cover letter discussion :)

All of your inline comments were valid and I agree with them. Noticing 
the single IC limitation was great!

I'll address all the findings if I keep the MFD approach.

Yours,
	-- Matti