[PATCH v2] gpio_keys.c: Send also event when EV_ABS axis button is released

From: Marian Flor
Date: Sat Feb 01 2025 - 11:20:33 EST


The input EV_ABS does not emit an event when the axis button is
released. It appears to libevdev as held, even when the axis
button is physically released. This behavior is also opposing
to the devicetree documentation for gpio-keys. Change the code
to additionally emit a zero valued event on axis button release.

Signed-off-by: Marian Flor <marian.flor@xxxxxxxxxx>
---
v2: No changes in patch itself, v2 got a commit description.

drivers/input/keyboard/gpio_keys.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 5eef66516e37..20a0327e8f9a 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -373,12 +373,10 @@ static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata)
return;
}

- if (type == EV_ABS) {
- if (state)
- input_event(input, type, button->code, button->value);
- } else {
+ if (type == EV_ABS)
+ input_event(input, type, button->code, state ? button->value : 0);
+ else
input_event(input, type, *bdata->code, state);
- }
}

static void gpio_keys_debounce_event(struct gpio_button_data *bdata)
--
2.39.5