Re: [PATCH net v4 3/3] net: stmmac: Specify hardware capability value when FIFO size isn't specified

[Guenter Roeck]

On 2/1/25 11:21, Andrew Lunn wrote:
> On Sat, Feb 01, 2025 at 11:14:41AM -0800, Guenter Roeck wrote:
> > Hi,
> >
> > On Mon, Jan 27, 2025 at 10:38:20AM +0900, Kunihiko Hayashi wrote:
> > > When Tx/Rx FIFO size is not specified in advance, the driver checks if
> > > the value is zero and sets the hardware capability value in functions
> > > where that value is used.
> > >
> > > Consolidate the check and settings into function stmmac_hw_init() and
> > > remove redundant other statements.
> > >
> > > If FIFO size is zero and the hardware capability also doesn't have upper
> > > limit values, return with an error message.
> > >
> > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> >
> > This patch breaks qemu's stmmac emulation, for example for
> > npcm750-evb. The error message is:
> > 	stmmaceth f0804000.eth: Can't specify Rx FIFO size
>
> Hi Guenter
>
> Please could you try the patch here:
>
> https://lore.kernel.org/lkml/915713e1-b67f-4eae-82c6-8dceae8f97a7@xxxxxxx/

Yes, that works.

Thanks, and sorry for the noise.

Guenter