RE: [PATCH] mei: Remove unused functions

[Usyskin, Alexander]

> -----Original Message-----
> From: Arnd Bergmann <arnd@xxxxxxxx>
> Sent: Friday, January 31, 2025 9:10 AM
> To: linux@xxxxxxxxxxx; Usyskin, Alexander <alexander.usyskin@xxxxxxxxx>;
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] mei: Remove unused functions
> 
> On Thu, Jan 30, 2025, at 02:26, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> 
> It looks like git-send-email failed to find your cleartext
> name in gitconfig.
> 
> > The following functions have been in the mei code for
> > a long time but have never been used.
> >
> > mei_txe_setup_satt2() was added in 2014 by
> > commit 32e2b59fca2c ("mei: txe: add hw-txe.c")
> >
> > mei_me_cl_rm_by_uuid_id() was added in 2015 by
> > commit 79563db9ddd3 ("mei: add reference counting for me clients")
> >
> > mei_cldev_uuid() was added in 2015 by
> > commit baeacd037697 ("mei: bus: export uuid and protocol version to
> mei_cl
> > bus drivers")
> >
> > mei_cldev_recv_nonblock() was added in 2016 by
> > commit 076802d00615 ("mei: bus: enable non-blocking RX")
> > it is the only user of mei_cldev_recv_nonblock_vtag().
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> 
> Makes sense to me. IIRC there are part of mei that are only
> used by out of tree code, but this is normally discouraged,
> so no objections from me on that.
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> 
>       Arnd

Let out of tree code bring them, if needed.

Reviewed-by:  Alexander Usyskin <alexander.usyskin@xxxxxxxxx>


- - 
Thanks,
Sasha