question about firmware caching and relying on it (CONFIG_FW_CACHE)

[Dave Airlie]

Hi,

I'm asking to see if there is any chance of consensus on having a
driver rely on (select) FW_CACHE. Nobody currently does.

Currently FW_CACHE is an optional feature (that distros may or may not
configure off), where we will cache loaded firmwares to avoid problems
over suspend/resume (and speed up resume).

I've just discovered a problem in nouveau's suspend code when the
FW_CACHE is turned off, it tries to load a few in it's suspend path
for certain scenarios. Enabling FW_CACHE fixes this, but I'm unsure if
that is considered properly fixing it or should FW_CACHE just be
considered an optimisation.

Do I
a) select FW_CACHE in nouveau Kconfig
b) fix nouveau to avoid loading the fw at suspend time (effectively
caching it itself?)

Dave.