Re: [PATCHv4 12/17] zsmalloc: factor out pool locking helpers
From: Sergey Senozhatsky
Date: Sun Feb 02 2025 - 23:57:18 EST
On (25/01/31 15:46), Yosry Ahmed wrote:
> > +static void pool_write_unlock(struct zs_pool *pool)
> > +{
> > + write_unlock(&pool->lock);
> > +}
> > +
> > +static void pool_write_lock(struct zs_pool *pool)
> > +{
> > + write_lock(&pool->lock);
> > +}
> > +
> > +static void pool_read_unlock(struct zs_pool *pool)
> > +{
> > + read_unlock(&pool->lock);
> > +}
> > +
> > +static void pool_read_lock(struct zs_pool *pool)
> > +{
> > + read_lock(&pool->lock);
> > +}
> > +
> > +static bool pool_lock_is_contended(struct zs_pool *pool)
> > +{
> > + return rwlock_is_contended(&pool->lock);
> > +}
> > +
> > static inline void zpdesc_set_first(struct zpdesc *zpdesc)
> > {
> > SetPagePrivate(zpdesc_page(zpdesc));
> > @@ -290,7 +315,7 @@ static bool ZsHugePage(struct zspage *zspage)
> > return zspage->huge;
> > }
> >
> > -static void migrate_lock_init(struct zspage *zspage);
> > +static void lock_init(struct zspage *zspage);
>
> Seems like this change slipped in here, with a s/migrate_lock/lock
> replacement if I have to make a guess :P
Look, it compiles! :P