Re: [PATCH 03/33] dt-bindings: clock: document exynos7870 clock driver CMU bindings

[Krzysztof Kozlowski]

On Mon, Feb 03, 2025 at 12:39:24AM +0530, Kaustabh Chakraborty wrote:

Subject - drop driver. Bindings are about hardware. This applies to all
your bindings patches

> +        clock-names:
> +          items:
> +            - const: oscclk
> +            - const: gout_mif_cmu_mfcmscl_mfc
> +            - const: gout_mif_cmu_mfcmscl_mscl
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,exynos7870-cmu-peri
> +

Drop blank line

> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: External reference clock (26 MHz)
> +            - description: CMU_PERI bus clock (from CMU_MIF)
> +            - description: SPI0 clock (from CMU_MIF)
> +            - description: SPI1 clock (from CMU_MIF)
> +            - description: SPI2 clock (from CMU_MIF)
> +            - description: SPI3 clock (from CMU_MIF)
> +            - description: SPI4 clock (from CMU_MIF)
> +            - description: UART0 clock (from CMU_MIF)
> +            - description: UART1 clock (from CMU_MIF)
> +            - description: UART2 clock (from CMU_MIF)
> +
> +        clock-names:
> +          items:
> +            - const: oscclk
> +            - const: gout_mif_cmu_peri_bus
> +            - const: gout_mif_cmu_peri_spi0
> +            - const: gout_mif_cmu_peri_spi1
> +            - const: gout_mif_cmu_peri_spi2
> +            - const: gout_mif_cmu_peri_spi3
> +            - const: gout_mif_cmu_peri_spi4
> +            - const: gout_mif_cmu_peri_uart0
> +            - const: gout_mif_cmu_peri_uart1
> +            - const: gout_mif_cmu_peri_uart2
> +
> +required:
> +  - compatible
> +  - "#clock-cells"
> +  - clocks
> +  - clock-names
> +  - reg

required block is just after properties.

> +
> +additionalProperties: false
> +
> +examples:
> +  # Clock controller node for CMU_PERI

Drop

> +  - |
> +    #include <dt-bindings/clock/exynos7870.h>
> +
> +    cmu_peri: clock-controller@101F0000 {

Lowercase hex

> +      compatible = "samsung,exynos7870-cmu-peri";
> +      reg = <0x101f0000 0x1000>;
> +      #clock-cells = <1>;
> +
> +      clock-names = "oscclk",
> +                    "gout_mif_cmu_peri_bus",
> +                    "gout_mif_cmu_peri_spi0",
> +                    "gout_mif_cmu_peri_spi1",
> +                    "gout_mif_cmu_peri_spi2",
> +                    "gout_mif_cmu_peri_spi3",
> +                    "gout_mif_cmu_peri_spi4",
> +                    "gout_mif_cmu_peri_uart0",
> +                    "gout_mif_cmu_peri_uart1",
> +                    "gout_mif_cmu_peri_uart2";
> +      clocks = <&oscclk>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_BUS>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_SPI0>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_SPI1>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_SPI2>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_SPI3>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_SPI4>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_UART0>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_UART1>,
> +               <&cmu_mif CLK_GOUT_MIF_CMU_PERI_UART2>;
> +    };
> +
> +...
> -- 
> 2.48.1
>