Re: [PATCH] debugfs: add fsd's methods initialization

From: Greg KH
Date: Mon Feb 03 2025 - 03:18:36 EST


On Mon, Feb 03, 2025 at 11:27:56AM +0800, Edward Adam Davis wrote:
> syzbot reported a uninit-value in full_proxy_unlocked_ioctl. [1]
>
> The newly created fsd does not initialize methods, and increases the
> initialization of methods for fsd.
>
> [1]
> BUG: KMSAN: uninit-value in full_proxy_unlocked_ioctl+0xed/0x3a0 fs/debugfs/file.c:399
> full_proxy_unlocked_ioctl+0xed/0x3a0 fs/debugfs/file.c:399
> vfs_ioctl fs/ioctl.c:51 [inline]
> __do_sys_ioctl fs/ioctl.c:906 [inline]
> __se_sys_ioctl+0x246/0x440 fs/ioctl.c:892
> __x64_sys_ioctl+0x96/0xe0 fs/ioctl.c:892
> x64_sys_call+0x19f0/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:17
> do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> Fixes: 41a0ecc0997c ("debugfs: get rid of dynamically allocation proxy_ops")
> Reported-by: syzbot+8928e473a91452caca2f@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=8928e473a91452caca2f
> Tested-by: syzbot+8928e473a91452caca2f@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Edward Adam Davis <eadavis@xxxxxx>
> ---
> fs/debugfs/file.c | 1 +
> 1 file changed, 1 insertion(+)

Is this still an issue on 6.14-rc1, specifically after commit
57b314752ec0 ("debugfs: Fix the missing initializations in
__debugfs_file_get()")?

thanks,

greg k-h