Re: [PATCH v2 2/3] dt-bindings: firmware: stratix10: Convert to json-schema

[Mahesh Rao]

Hi Rob,

On 31-01-2025 08:56 pm, Rob Herring wrote:
> On Fri, Jan 31, 2025 at 06:17:25PM +0800, Mahesh Rao wrote:
> > Convert intel,stratix10-svc service layer devicetree
> > binding file from freeform format to json-schema.
> >
> > Also added DT binding for optional stratix10-soc
> > FPGA manager child node.
> >
> > Signed-off-by: Mahesh Rao<mahesh.rao@xxxxxxxxx>
> > ---
> > +maintainers:
> > +  - Dinh Nguyen<dinguyen@xxxxxxxxxx>
> > +  - Mahesh Rao<mahesh.rao@xxxxxxxxxx>
> > +
> > +description:
> You need '>' on the end to preserve paragraphs.
 Will make the change.
> +      - intel,stratix10-svc
> +      - intel,agilex-svc
> +
> +  method:
> +    description: |
> +                 Supervisory call method to be used to communicate with the
> +                 secure service layer.
> +                 Permitted values are:
> +                 - "smc" : SMC #0, following the SMCCC
> +                 - "hvc" : HVC #0, following the SMCCC
> Indent by 2 more than 'description'.
OK, will add the change.
> > +  memory-region:
> > +    maxItems: 1
> > +    description:
> > +      phandle to a reserved memory region for the service layer driver to
> > +      communicate with the secure device manager. For more details see
> > +      Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt.
> Please read what that file says.

reserved-memory is moved to dtschema, shall I change this to the following?

memory-region:
    maxItems: 1
    description:
      Phandle to a reserved memory region for the service layer driver to
      communicate with the secure device manager.
      (See reserved-memory in dtschema project.)

Is this what is required?

Best regards

Mahesh Rao