Re: [PATCH] cpufreq: airoha: add CONFIG_OF dependency

[Arnd Bergmann]

On Mon, Feb 3, 2025, at 10:21, Viresh Kumar wrote:
>
> Going to send this patch now, lemme know if it looks okay:
>
>
>     It would be possible to mark the variable as __maybe_unused to shut up
>     that warning, but a Kconfig dependency seems more appropriate as this still
>     allows build testing in allmodconfig and randconfig builds on all
>     architectures.
>
>     An earlier commit, b865a8404642 ("cpufreq: airoha: Depends on OF"),
>     tried to fix it incorrectly. ARCH_AIROHA already requires CONFIG_OF, so
>     this change does nothing, and the dependency is still missing for the
>     COMPILE_TEST case.
>
>     Fix it properly.
>
>     Fixes: 84cf9e541ccc ("cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver")
>     Fixes: b865a8404642 ("cpufreq: airoha: Depends on OF")
>     Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>     [ Viresh: updated commit log and fixed rebase conflict ]
>     Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Looks good to me, thanks!

    Arnd