Re: [PATCH v2 2/3] dt-bindings: firmware: stratix10: Convert to json-schema

[Mahesh Rao]

Hi Krzysztof,

On 03-02-2025 04:45 pm, Krzysztof Kozlowski wrote:
> On 03/02/2025 11:42, Mahesh Rao wrote:
> > OK, will add the change.
> > > > +  memory-region:
> > > > +    maxItems: 1
> > > > +    description:
> > > > +      phandle to a reserved memory region for the service layer driver to
> > > > +      communicate with the secure device manager. For more details see
> > > > +      Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt.
> > > Please read what that file says.
> > reserved-memory is moved to dtschema, shall I change this to the following?
> >
> > memory-region:
> >       maxItems: 1
> >       description:
> >         Phandle to a reserved memory region for the service layer driver to
> >         communicate with the secure device manager.
> >         (See reserved-memory in dtschema project.)
> >
> > Is this what is required?
> Drop:
> "Phandle to a"
> "(See reserved-memory in dtschema project.)"
>
> They are redundant, because this cannot be anything else than phandle
> and there is no need to say where each property is. You don't add such
> statement about clocks, interrupts, reg or compatible, so no need for
> memory-region.
>
> Removal makes the description actually nicely compact and accurate. Just
> how efficient text and code should be.
>
>
> Best regards,
> Krzysztof

OK, thanks for the help. I will make the change.

Best regards

Mahesh Rao