[PATCH v1 4/7] gpio: 74x164: Make use of the macros from bits.h
From: Andy Shevchenko
Date: Mon Feb 03 2025 - 07:19:43 EST
Make use of BIT() and GENMASK() where it makes sense.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/gpio/gpio-74x164.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
index 7844f8a58834..0f720d539fa7 100644
--- a/drivers/gpio/gpio-74x164.c
+++ b/drivers/gpio/gpio-74x164.c
@@ -47,7 +47,7 @@ static int gen_74x164_get_value(struct gpio_chip *gc, unsigned offset)
guard(mutex)(&chip->lock);
- return (chip->buffer[bank] >> pin) & 0x1;
+ return !!(chip->buffer[bank] & BIT(pin));
}
static void gen_74x164_set_value(struct gpio_chip *gc,
@@ -60,9 +60,9 @@ static void gen_74x164_set_value(struct gpio_chip *gc,
guard(mutex)(&chip->lock);
if (val)
- chip->buffer[bank] |= (1 << pin);
+ chip->buffer[bank] |= BIT(pin);
else
- chip->buffer[bank] &= ~(1 << pin);
+ chip->buffer[bank] &= ~BIT(pin);
__gen_74x164_write_config(chip);
}
--
2.43.0.rc1.1336.g36b5255a03ac