Re: [PATCH v4 3/3] can: flexcan: add NXP S32G2/S32G3 SoC support

[Ciprian Marian Costea]

On 12/4/2024 1:48 PM, Marc Kleine-Budde wrote:
> On 04.12.2024 13:38:51, Ciprian Marian Costea wrote:
> > > Unrelated to this patch, but I want to extend the "FLEXCAN hardware
> > > feature flags" table in "flexcan.h". Can you provide the needed
> > > information?
> >
> > I would say the following S32G related information could be added:
> >
> > > > /* FLEXCAN hardware feature flags
> > > >    *
> > > >    * Below is some version info we got:
> > > >    *    SOC   Version   IP-Version  Glitch- [TR]WRN_INT IRQ Err Memory err RTR rece-   FD Mode     MB
> > > >    *                                Filter? connected?  Passive detection  ption in MB Supported?
> > > >    * MCF5441X FlexCAN2  ?               no       yes        no       no        no           no     16
> > > >    *    MX25  FlexCAN2  03.00.00.00     no        no        no       no        no           no     64
> > > >    *    MX28  FlexCAN2  03.00.04.00    yes       yes        no       no        no           no     64
> > > >    *    MX35  FlexCAN2  03.00.00.00     no        no        no       no        no           no     64
> > > >    *    MX53  FlexCAN2  03.00.00.00    yes        no        no       no        no           no     64
> > > >    *    MX6s  FlexCAN3  10.00.12.00    yes       yes        no       no       yes           no     64
> > > >    *    MX8QM FlexCAN3  03.00.23.00    yes       yes        no       no       yes          yes     64
> > > >    *    MX8MP FlexCAN3  03.00.17.01    yes       yes        no      yes       yes          yes     64
> > > >    *    VF610 FlexCAN3  ?               no       yes        no      yes       yes?          no     64
> > > >    *  LS1021A FlexCAN2  03.00.04.00     no       yes        no       no       yes           no     64
> > > >    *  LX2160A FlexCAN3  03.00.23.00     no       yes        no      yes       yes          yes     64
> >        *  S32G2/S32G3 FlexCAN3 03.00.39.00  no       yes        no      yes       yes          yes    128
> > > >    *
> > > >    * Some SOCs do not have the RX_WARN & TX_WARN interrupt line connected.
> > > >    */
> >
> > Would you like me to send another version of this patchset with above
> > information included ?
>
> No. Once we have Krzysztof's ACK for the DT binding changes, I'll take
> this series.
>
> I think we'll make that a separate patch and maybe add more information.
>
> regards,
> Marc

Hello Krzysztof,

I've addressed your feedback from the previous version of this patchset.

Is the current version ok from your point of view with respect to DT 
bindings changes?

Regards,
Ciprian