Re: [PATCH 2/3] regulator: dummy: convert to use the faux bus

[Greg Kroah-Hartman]

On Mon, Feb 03, 2025 at 03:39:06PM +0000, Mark Brown wrote:
> On Mon, Feb 03, 2025 at 03:25:18PM +0100, Greg Kroah-Hartman wrote:
> > The dummy regulator driver does not need to create a platform device, it
> > only did so because it was simple to do.  Change it over to use the
> > faux bus instead as this is NOT a real platform device, and it makes
> > the code even smaller than before.
> 
> No, they did this because you explicitly asked that this be done....

I did?  What was it attempting to be before this?  I don't remember that
at all, sorry.

> > -static int dummy_regulator_probe(struct platform_device *pdev)
> > +static int dummy_regulator_probe(struct faux_device *vdev)
> 
> Just dev or fdev - we could just pass a struct device in here, we don't
> actually care that it's a platform device at this point.  Having the
> abbreviation mismatch with the device type is odd.

Ah, that's a mistake from my first pass when this was a "struct
virtual_device" and I called this "vdev".  I'll go fix that up, thanks.

greg k-h