Re: [PATCH v2 5/9] powerpc: Use preempt_model_str().

From: Sebastian Andrzej Siewior
Date: Mon Feb 03 2025 - 11:01:14 EST


On 2025-02-03 16:19:06 [+0100], Christophe Leroy wrote:
>
>
> Le 03/02/2025 à 15:16, Sebastian Andrzej Siewior a écrit :
> > Use preempt_model_str() instead of manually conducting the preemption
> > model. Use pr_emerg() instead of printk() to pass a loglevel.
>
> Why use pr_emerg() for that line and not all other ones ?

checkpatch complained for the current printk() line and this looks like
an emergency coming from die().

> The purpose of using printk() is to get it at the level defined by
> CONFIG_MESSAGE_LOGLEVEL_DEFAULT and I think it is important to have the full
> Oops block at the same level.

Okay. So "printk(KERN_DEFAULT " then.

Sebastian