Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes

From: Krzysztof Kozlowski
Date: Mon Feb 03 2025 - 11:31:07 EST


On 28/01/2025 07:27, Varadarajan Narayanan wrote:
>
> @@ -479,6 +519,230 @@ frame@b128000 {
> status = "disabled";
> };
> };
> +
> + pcie1: pcie@18000000 {
> + compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
> + reg = <0x00088000 0x3000>,

So as Konrad pointed out now, this was never tested. It's not we who
should run tests for you. It's you.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.

Best regards,
Krzysztof