Re: [PATCH 1/2] f2fs: don't kobject_put in the error case
From: Jaegeuk Kim
Date: Mon Feb 03 2025 - 13:34:16 EST
I checked this patch is wrong. Sorry for the noise.
On 01/31, Jaegeuk Kim wrote:
> Fix a wrong kobject_put in the error path.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> ---
> fs/f2fs/sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index d15c68b28952..001e97cd0a96 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -1605,7 +1605,7 @@ int __init f2fs_init_sysfs(void)
> ret = kobject_init_and_add(&f2fs_feat, &f2fs_feat_ktype,
> NULL, "features");
> if (ret)
> - goto put_kobject;
> + goto unregister_out;
>
> f2fs_proc_root = proc_mkdir("fs/f2fs", NULL);
> if (!f2fs_proc_root) {
> @@ -1616,6 +1616,7 @@ int __init f2fs_init_sysfs(void)
> return 0;
> put_kobject:
> kobject_put(&f2fs_feat);
> +unregister_out:
> kset_unregister(&f2fs_kset);
> return ret;
> }
> --
> 2.48.1.362.g079036d154-goog