Re: [PATCH] perf: Always feature test reallocarray
From: Namhyung Kim
Date: Mon Feb 03 2025 - 14:02:43 EST
On Wed, 29 Jan 2025 15:44:05 +0000, James Clark wrote:
> This is also used in util/comm.c now, so instead of selectively doing
> the feature test, always do it. If it's ever used anywhere else it's
> less likely to cause another build failure.
>
> This doesn't remove the need to manually include libc_compat.h, and
> missing that will still cause an error for glibc < 2.26. There isn't a
> way to fix that without poisoning reallocarray like libbpf did, but that
> has other downsides like making memory debugging tools less useful. So
> for Perf keep it like this and we'll have to fix up any missed includes.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung