Re: [PATCH v2 2/2] KVM: SVM: Limit AVIC physical max index based on configured max_vcpu_ids
From: kernel test robot
Date: Mon Feb 03 2025 - 16:07:35 EST
Hi Naveen,
kernel test robot noticed the following build errors:
[auto build test ERROR on eb723766b1030a23c38adf2348b7c3d1409d11f0]
url: https://github.com/intel-lab-lkp/linux/commits/Naveen-N-Rao-AMD/KVM-SVM-Increase-X2AVIC-limit-to-4096-vcpus/20250203-144127
base: eb723766b1030a23c38adf2348b7c3d1409d11f0
patch link: https://lore.kernel.org/r/b79610c60de53048f3fda942fd45973c4ab1de97.1738563890.git.naveen%40kernel.org
patch subject: [PATCH v2 2/2] KVM: SVM: Limit AVIC physical max index based on configured max_vcpu_ids
config: x86_64-randconfig-008-20250203 (https://download.01.org/0day-ci/archive/20250204/202502040421.WqVoesZI-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250204/202502040421.WqVoesZI-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502040421.WqVoesZI-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from arch/x86/kvm/svm/avic.c:20:
In file included from include/linux/kvm_host.h:16:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> arch/x86/kvm/svm/avic.c:88:66: error: expected ')'
88 | static inline u32 avic_get_max_physical_id(struct kvm *kvm, bool x2apic_mode)
| ^
arch/x86/include/asm/apic.h:258:23: note: expanded from macro 'x2apic_mode'
258 | #define x2apic_mode (0)
| ^
arch/x86/kvm/svm/avic.c:88:66: note: to match this '('
arch/x86/include/asm/apic.h:258:22: note: expanded from macro 'x2apic_mode'
258 | #define x2apic_mode (0)
| ^
arch/x86/kvm/svm/avic.c:88:66: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
88 | static inline u32 avic_get_max_physical_id(struct kvm *kvm, bool x2apic_mode)
| ^
arch/x86/include/asm/apic.h:258:23: note: expanded from macro 'x2apic_mode'
258 | #define x2apic_mode (0)
| ^
2 warnings and 1 error generated.
vim +88 arch/x86/kvm/svm/avic.c
87
> 88 static inline u32 avic_get_max_physical_id(struct kvm *kvm, bool x2apic_mode)
89 {
90 u32 avic_max_physical_id = x2apic_mode ? x2avic_max_physical_id : AVIC_MAX_PHYSICAL_ID;
91
92 /*
93 * Assume vcpu_id is the same as APIC ID. Per KVM_CAP_MAX_VCPU_ID, max_vcpu_ids
94 * represents the max APIC ID for this vm, rather than the max vcpus.
95 */
96 return min(kvm->arch.max_vcpu_ids - 1, avic_max_physical_id);
97 }
98
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki