Re: [PATCH net-next] mlx4: Remove unused functions

From: Tariq Toukan
Date: Mon Feb 03 2025 - 16:44:18 EST




On 03/02/2025 20:52, linux@xxxxxxxxxxx wrote:
From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>

The last use of mlx4_find_cached_mac() was removed in 2014 by
commit 2f5bb473681b ("mlx4: Add ref counting to port MAC table for RoCE")

mlx4_zone_free_entries() was added in 2014 by
commit 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator")
but hasn't been used. (The _unique version is used)

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
---
drivers/net/ethernet/mellanox/mlx4/alloc.c | 22 ----------------------
drivers/net/ethernet/mellanox/mlx4/mlx4.h | 6 ------
drivers/net/ethernet/mellanox/mlx4/port.c | 20 --------------------
include/linux/mlx4/device.h | 1 -
4 files changed, 49 deletions(-)


Thanks for your patch.

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Tariq