Re: [PATCH v2 1/9] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node

[Judith Mendez]

Hi Andrew,

On 1/31/25 5:40 PM, Andrew Davis wrote:
> On 1/31/25 3:46 PM, Judith Mendez wrote:
> > From: Hari Nagalla <hnagalla@xxxxxx>
>
> Subject should capitalize R5F

Will fix in v3, thanks

> > AM62 SoC devices have a single core R5F processor in wakeup domain.
> > The R5F processor in wakeup domain is used as a device manager
> > for the SoC.
> >
> > Signed-off-by: Devarsh Thakkar <devarsht@xxxxxx>
> > Signed-off-by: Hari Nagalla <hnagalla@xxxxxx>
> > Signed-off-by: Judith Mendez <jm@xxxxxx>
> > ---
> > Changes since v1:
> > - disable each device node in the voltage domain files and
> >    enable at the board level file
> > - fix firmware names
> > ---
> >   arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 25 ++++++++++++++++++++++
> >   1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi 
> > b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > index 9b8a1f85aa15c..12b1520974ade 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > @@ -106,6 +106,31 @@ wkup_rti0: watchdog@2b000000 {
> >           status = "reserved";
> >       };
> > +    wkup_r5fss0: r5fss@78000000 {
> > +        compatible = "ti,am62-r5fss";
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > +                 <0x78100000 0x00 0x78100000 0x8000>;
>
> Odd alignment, looks like you have an extra tab on the above line

Hmm missed this, thanks will fix.

~ Judith

> Andrew
>
> > +        power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> > +        status = "disabled";
> > +
> > +        wkup_r5fss0_core0: r5f@78000000 {
> > +            compatible = "ti,am62-r5f";
> > +            reg = <0x78000000 0x00008000>,
> > +                  <0x78100000 0x00008000>;
> > +            reg-names = "atcm", "btcm";
> > +            ti,sci = <&dmsc>;
> > +            ti,sci-dev-id = <121>;
> > +            ti,sci-proc-ids = <0x01 0xff>;
> > +            resets = <&k3_reset 121 1>;
> > +            firmware-name = "am62-wkup-r5f0_0-fw";
> > +            ti,atcm-enable = <1>;
> > +            ti,btcm-enable = <1>;
> > +            ti,loczrama = <1>;
> > +        };
> > +    };
> > +
> >       wkup_vtm0: temperature-sensor@b00000 {
> >           compatible = "ti,j7200-vtm";
> >           reg = <0x00 0xb00000 0x00 0x400>,