Re: [PATCH] dt-bindings: mmc: move compatible property to its specific binding

[neil . armstrong]

Hi,

On 04/02/2025 05:24, Dharma.B@xxxxxxxxxxxxx wrote:
> Rob / Conor,
>
> On 20/01/25 10:00 am, Dharma B wrote:
> > Hi Rob/Conor,
> >
> > On 09/01/25 2:26 am, Martin Blumenstingl wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > the content is safe
> > >
> > > Hi Dharma,
> > >
> > > On Wed, Jan 8, 2025 at 4:11 AM <Dharma.B@xxxxxxxxxxxxx> wrote:
> > > [...]
> > > > "One issue is 'compatible' is required. Either that would have to be
> > > > dropped as required."
> > > >
> > > > Instead of just dropping it from "required:", I removed the property
> > > > itself and moved it to another binding.
> > > >
> > > > I will send a v2 by removing it from the required, will it be fine?
> > > For me this is fine.
> > >
> > > My understanding is that if we drop the compatible property completely
> > > then any compatible string will be allowed (for example: compatible =
> > > "random,name"). This is because mmc-slot.yaml inherits the properties
> > > from mmc-controller-common.yaml which itself has
> > > "additionalProperties: true".
> > > However, if we allow it but make it optional it means that there's
> > > only two valid states:
> > > - no compatible property (on the Atmel / Microchip SoCs)
> > > - a compatible property with the value "mmc-slot" (as used on Amlogic
> > > Meson and Cavium Thunder SoCs)
> > > - (anything else is considered invalid)
> > >
> > > Rob, Conor: can confirm this or correct me wherever I got something
> > > wrong.
> > > I hope that your feedback will help Dharma write a good patch
> > > description for v2.
> >
> > Shall I proceed with v2 by dropping the compatible from the required
> > property list?
>
> I hope this email finds you well. Just following up on my previous
> message from 20/01/25, as it seems to have achieved an impressive
> feat—perfect stealth mode. Either my patch is so flawless that it left
> everyone speechless, or it has been silently sacrificed to the inbox
> gods. 😅
>
> If there are any concerns, feedback, or a secret ritual I need to
> perform to get a response, please do let me know. Would love to hear
> your thoughts when time permits.
>
> Looking forward to breaking the radio silence!

Just send a v2 as RFC, so we can comment on it.

Thanks,
Neil

> > > Best regards,
> > > Martin