Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes

[Dhruva Gole]

On Jan 24, 2025 at 13:16:44 -0600, Rob Herring (Arm) wrote:
> Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> "syscon" compatible") broke drivers which call device_node_to_regmap()
> on nodes without a "syscon" compatible. Restore the prior behavior for
> device_node_to_regmap().
> 
> This also makes using device_node_to_regmap() incompatible with
> of_syscon_register_regmap() again, so add kerneldoc for
> device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> how and when each one should be used.
> 
> Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> Cc: Will McVicker <willmcvicker@xxxxxxxxxx>
> Cc: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> Reported-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
>  drivers/mfd/syscon.c | 29 ++++++++++++++++++++++++++---
>  1 file changed, 26 insertions(+), 3 deletions(-)

Tested this for basic boot on TI K3 AM625-SK with next-20250204.
Tested-by: Dhruva Gole <d-gole@xxxxxx>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated