Re: [PATCH v2] scanf: convert self-test to KUnit

From: Tamir Duberstein
Date: Tue Feb 04 2025 - 05:25:13 EST


On Tue, Feb 4, 2025 at 3:39 AM Petr Mladek <pmladek@xxxxxxxx> wrote:
>
> On Mon 2025-02-03 06:48:05, Tamir Duberstein wrote:

[...]

> > diff --git a/lib/Makefile b/lib/Makefile
> > index d5cfc7afbbb8..a53cf6dd1505 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -85,7 +85,6 @@ obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_keys.o
> > obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o
> > obj-$(CONFIG_TEST_DYNAMIC_DEBUG) += test_dynamic_debug.o
> > obj-$(CONFIG_TEST_PRINTF) += test_printf.o
> > -obj-$(CONFIG_TEST_SCANF) += test_scanf.o
> >
> > obj-$(CONFIG_TEST_BITMAP) += test_bitmap.o
> > ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_KASAN),yy)
> > @@ -373,8 +372,9 @@ CFLAGS_bitfield_kunit.o := $(DISABLE_STRUCTLEAK_PLUGIN)
> > obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
> > obj-$(CONFIG_CHECKSUM_KUNIT) += checksum_kunit.o
> > obj-$(CONFIG_UTIL_MACROS_KUNIT) += util_macros_kunit.o
> > -obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> > obj-$(CONFIG_HASHTABLE_KUNIT_TEST) += hashtable_test.o
> > +obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
>
> This looks like an unrelated change.

You're right. I was trying to keep this bit alphabetized but there's
no pattern here. I'll also move the scanf entry back to where it was.

> > +obj-$(CONFIG_SCANF_KUNIT_TEST) += scanf_kunit.o
> > obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> > obj-$(CONFIG_BITS_TEST) += test_bits.o
> > obj-$(CONFIG_CMDLINE_KUNIT_TEST) += cmdline_kunit.o
>
> Best Regards,
> Petr

Thanks.
Tamir