Re: [PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX

From: Paolo Abeni
Date: Tue Feb 04 2025 - 07:31:46 EST


On 2/3/25 11:39 PM, Mina Almasry wrote:
> Add support for devmem TX in ncdevmem.
>
> This is a combination of the ncdevmem from the devmem TCP series RFCv1
> which included the TX path, and work by Stan to include the netlink API
> and refactored on top of his generic memory_provider support.
>
> Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx>
> Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>

Usually the self-tests are included towards the end of the series, to
help reviewers building-up on previous patches knowledge.

> .../selftests/drivers/net/hw/ncdevmem.c | 300 +++++++++++++++++-
> 1 file changed, 289 insertions(+), 11 deletions(-)

Why devmem.py is not touched? AFAICS the test currently run ncdevmem
only in server (rx) mode, so the tx path is not actually exercised ?!?

/P