Re: [PATCH v8 11/13] drm/atomic-helper: Separate out bridge pre_enable/post_disable from enable/disable

From: Tomi Valkeinen
Date: Tue Feb 04 2025 - 08:56:19 EST


Hi,

On 26/01/2025 21:15, Aradhya Bhatia wrote:
The encoder-bridge ops occur by looping over the new connector states of
the display pipelines. The enable sequence runs as follows -

- pre_enable(bridge),
- enable(encoder),
- enable(bridge),

while the disable sequnce runs as follows -

- disable(bridge),
- disable(encoder),
- post_disable(bridge).

Separate out the pre_enable(bridge), and the post_disable(bridge)
operations into separate functions each.

This patch keeps the sequence same for any singular disaplay pipe, but
changes the sequence across multiple display pipelines.

This patch is meant to be an interim patch, to cleanly pave the way for
the sequence re-ordering patch, and maintain bisectability in the
process.

Signed-off-by: Aradhya Bhatia <aradhya.bhatia@xxxxxxxxx>
---
drivers/gpu/drm/drm_atomic_helper.c | 92 +++++++++++++++++++++++++++--
1 file changed, 88 insertions(+), 4 deletions(-)

With the issue Jayesh pointed out fixed:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

Tomi