Re: [PATCH v1 1/6] serial: port: Assign ->iotype correctly when ->iobase is set

From: Greg Kroah-Hartman
Date: Tue Feb 04 2025 - 09:00:48 EST


On Fri, Jan 24, 2025 at 06:10:46PM +0200, Andy Shevchenko wrote:
> Currently the ->iotype is always assigned to the UPIO_MEM when
> the respective property is not found. However, this will not
> support the cases when user wants to have UPIO_PORT to be set
> or preserved. Support this scenario by checking ->iobase value
> and default the ->iotype respectively.
>
> Fixes: 1117a6fdc7c1 ("serial: 8250_of: Switch to use uart_read_port_properties()")
> Fixes: e894b6005dce ("serial: port: Introduce a common helper to read properties")

You forgot the cc: stable lines. I'll go add them in, but be more
careful next time please.

thanks,

greg k-h