Re: [PATCH] staging: gpib: Resolve prefixing 0x with decimal

[Greg KH]

On Tue, Feb 04, 2025 at 07:21:31PM +0530, Ajith P V wrote:
> - pr_info() of hp_82341_attach() in hp_82341 uses 0x%u which is defective.
> - The iobase is of u32 and correct prefix is 0x%x.
> - This error reported by checkpatch with below message:
>   ERROR: Prefixing 0x with decimal output is defective.
> 
> Signed-off-by: Ajith P V <ajithpv.linux@xxxxxxxxx>
> ---
>  drivers/staging/gpib/hp_82341/hp_82341.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpib/hp_82341/hp_82341.c
> index 800f99c05566..740c450914dc 100644
> --- a/drivers/staging/gpib/hp_82341/hp_82341.c
> +++ b/drivers/staging/gpib/hp_82341/hp_82341.c
> @@ -723,7 +723,7 @@ static int hp_82341_attach(gpib_board_t *board, const gpib_board_config_t *confi
>  		hp_priv->hw_version = HW_VERSION_82341C;
>  		hp_priv->io_region_offset = 0x400;
>  	}
> -	pr_info("hp_82341: base io 0x%u\n", iobase);
> +	pr_info("hp_82341: base io 0x%x\n", iobase);

When drivers work properly, they are quiet.  Lines like this should just
be removed.

thanks,

greg k-h