Re: [PATCH] pipe: don't update {a,c,m}time for anonymous pipes
From: Oleg Nesterov
Date: Tue Feb 04 2025 - 09:40:02 EST
On 02/04, Mateusz Guzik wrote:
>
> > + if (ret > 0 && !is_pipe_inode(file_inode(filp))) {
>
> Total nit in case there is a v2:
>
> ret is typically > 0 and most of the time this is going to be an
> anonymous pipe, so I would swap these conditions around.
>
> A not nit is that "is_pipe_inode" is imo misleading -- a named pipe
> inode is also a pipe inode. How about "is_anon_pipe"?
OK, I'll wait for other reviews and send v2 with the changes you suggest.
Oleg.