Re: [PATCH v13 2/8] mm: rust: add vm_area_struct methods that require read access

[Liam R. Howlett]

* Alice Ryhl <aliceryhl@xxxxxxxxxx> [250204 07:46]:
> On Mon, Feb 3, 2025 at 4:44 PM Liam R. Howlett <Liam.Howlett@xxxxxxxxxx> wrote:
> >
> > * Alice Ryhl <aliceryhl@xxxxxxxxxx> [250203 07:15]:
> >
> > Hi Alice,
> >
> > These comments are probably for my education.  I'm holding back my
> > training on naming and trying to reconcile the snake-case and upper case
> > camel of the rust language.
> >
> > > This adds a type called VmAreaRef which is used when referencing a vma
> >
> > How did you land on VmAreaRef?  Why not VmaRef?  We mostly use vma for
> > vmas today, not vm_area.  Is it because the header declares it
> > vm_area_struct?  I'd be happier with VmaRef, but I'm guessing this is a
> > direct translation from vm_area_struct?
> 
> Sorry missed this on my first pass.
> 
> Yes, it follows the C name. Happy to rename to VmaRef.

I don't want to cause churn on a v13 patch set and I've lived with the
verbose vm_area_struct..

It does cause function declarations to split lines frequently.

It's up to you, I'll accept it whatever way you decide.

Thanks,
Liam