[PATCH V2] kthread: Fix build warning variable 'ret' set but not used

From: Dhruva Gole
Date: Tue Feb 04 2025 - 11:09:48 EST


Fix the following build time warning in kthread:

kernel/kthread.c: In function 'kthread_affine_preferred':
>> kernel/kthread.c:861:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
861 | int ret;
| ^~~

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202501301528.t0cZVbnq-lkp@xxxxxxxxx/
Signed-off-by: Dhruva Gole <d-gole@xxxxxx>
---
Link to v1:
https://lore.kernel.org/lkml/20250204090838.214647-1-d-gole@xxxxxx/

Changelog:
- Use ret value toward the end return as per Kees' suggestion

---

kernel/kthread.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/kthread.c b/kernel/kthread.c
index 4005b13ebd7f..5dc5b0d7238e 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -859,7 +859,7 @@ int kthread_affine_preferred(struct task_struct *p, const struct cpumask *mask)
struct kthread *kthread = to_kthread(p);
cpumask_var_t affinity;
unsigned long flags;
- int ret;
+ int ret = 0;

if (!wait_task_inactive(p, TASK_UNINTERRUPTIBLE) || kthread->started) {
WARN_ON(1);
@@ -892,7 +892,7 @@ int kthread_affine_preferred(struct task_struct *p, const struct cpumask *mask)
out:
free_cpumask_var(affinity);

- return 0;
+ return ret;
}

/*

base-commit: 40b8e93e17bff4a4e0cc129e04f9fdf5daa5397e
--
2.34.1