Re: [PATCH v4] Weighted Interleave Auto-tuning

[Gregory Price]

On Tue, Feb 04, 2025 at 04:50:26PM +0900, Harry (Hyeonggon) Yoo wrote:
> On Tue, Jan 28, 2025 at 02:23:31PM -0800, Joshua Hahn wrote:
> 
> I believe the author has successfully addressed major concerns
> through the revisions. The interface and the code now look good to me.
> 
> Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
> 

Thank you!

> > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
> > index 80a3481c0470..cc94cba112dd 100644
> > --- a/drivers/acpi/numa/hmat.c
> > +++ b/drivers/acpi/numa/hmat.c
> > @@ -20,6 +20,7 @@
> >  #include <linux/list_sort.h>
> >  #include <linux/memregion.h>
> >  #include <linux/memory.h>
> > +#include <linux/mempolicy.h>
> 
> nit: is this #include directive necessary?

yes because hmat.c now calls
	mempolicy_set_node_perf(nid, coord))

and best practice is to "include what you use" to avoid hidden
dependency issues should another include be removed later.

~Gregory